fix(fujifilm_ratings.lua): improve the script and make it work again#495
fix(fujifilm_ratings.lua): improve the script and make it work again#495LucasGGamerM wants to merge 1 commit into
Conversation
I don't know what changed, but it broke the previous iteration of the script. So I fixed it and improved it a bit.
There was an error in the libraries. It was fixed around the time you submitted the PR, so the original code was working again.
The improvement checks all JPGs, not just Fuji jpgs. Since the name of the script is fujifilm_ratings users would get a rude surprise if all their JPGs had their ratings changed by the script. If you want to write a script that corrects ratings for JPGs that darktable doesn't automatically detect then it should be as a separate script. If you decide to do that, you probably want to check image.exif_maker to make sure that you are only changing ratings for maker images that are not understood by darktable. |
|
Thank you got the feedback, I will see what I can do about it (for some reason my fuji rafs don't have a ratings, while the JPGs do), so maybe another script shall be written |
2 participants
I don't know what changed between 9.2.0 and 9.3.0, but it broke the previous iteration of the script. So I fixed it and improved it a bit.
The main improvement here is that it also checks for JPGs, which I think is necessary. And it works again.